fix: Update package version of codemirror/view to fix carret low contrast #947
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@heygwangjin is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
heygwangjin
force-pushed
the
caret-contrast
branch
2 times, most recently
from
c1b7928 to
b12c5c7
Compare
heygwangjin
force-pushed
the
caret-contrast
branch
from
b12c5c7 to
5f9a977
Compare
* Update codemirror/view package version to fix low caret contrast on mobile safari
heygwangjin
force-pushed
the
caret-contrast
branch
from
5f9a977 to
cae2125
Compare
|
nice, thank you! |
|
Unfortunately we had to revert this because there's quite a nasty bug in the latest version — #974 |
|
@Rich-Harris I think this bug has also been reported by someone else (https://discuss.codemirror.net/t/cursor-position-issue-on-the-end-of-the-line/8866/5) The maintainer has fixed it in @codemirror/view version 6.35.2 (codemirror/view@2aa5d7f) However, after updating the package to version 6.35.2 and testing it locally, the Svelte compiler doesn’t seem to work properly. 
So, it seems like we need to keep an eye on this for a bit longer. |
To fix #925 issue, I reported this bug to codemirror and they fixed it. (codemirror/dev#1487)
So I updated package version of
codemirror/viewand we can see white caret in dark mode on mobile safari.Changed the version of codemirror in below packages.
Before
After