fix: make Safari rendering of summary elements the same as other browsers #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@BernieSumption is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Rich-Harris
approved these changes
Dec 9, 2024
|
fantastic, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Chromium-based browsers and Firefox, setting
display: blockordisplay: flexon a<summary>element will hide the expand/contract arrow icon. Svelte does this and provides alternative affordances to indicate whether the summary is open.Safari needs a bit more help, requiring
display:noneon the::-webkit-details-markerpseudoelement.This PR adds
::-webkit-details-markerto the 4 places I could find summary elements, making Safari consistent with other browsers.Tutorial navigation menu trigger button
Before:
After:
Tutorial navigation menu
Before:
After:
In site search
Before:
After:
In Text.svelte
e.g. on https://svelte.dev/blog/view-transitions
Before:
After: