Fix Responsive Issue in svelte.dev Homepage #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… responsive issue
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@kresnasatya is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Rich-Harris
approved these changes
Dec 12, 2024
|
Thank you — I removed the hardcoded dimensions and used a |
You're welcome. I just realize that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR is a fix of responsive issue in svelte.dev homepage: #982. I see the update version of
@sveltejs/enhanced-imgin commit d6a64f8 makes the svelte.dev homepage not responsive. If I see more detail, thesvelte-pronounciation.svgneeds to set width and height expicitly as the quick solution.I have see the PR of
@sveltejs/enhanced-imghttps://github.com/sveltejs/kit/pull/13126/files#diff-f318d5cf67f7e975aecc26dfb6056ae55058442cf36dd7e6f53c4a292edeb2d9. But, it looks like Ben forgot to test thesvelte-pronounciation.svgasset.Here's the GIF video demonstration (please wait for seconds to make it appears).
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.