Skip to content

fix: return ast from compile #10160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: return ast from compile #10160

wants to merge 1 commit into from

Conversation

dummdidumm
Copy link
Member

Was returned from Svelte 4's compile method, and language tools uses it in various places for perf reasons (not doing double parses unnecessarily if you need both)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Was returned from Svelte 4's compile method, and language tools uses it in various places for perf reasons (not doing double parses unnecessarily if you need both)
Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: c87affd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 1:43pm

@dummdidumm
Copy link
Member Author

Mhm wait this is incomplete, it also needs to have an option which AST to return in this case. Mhhhhhhhhhhhhhhhhm. Maybe it's better to instead change the API so that compile can also take an AST, skipping the work. Then again, language tools would have the old AST but the compiler would require the new one. Gah, this is stupid.

@dummdidumm dummdidumm marked this pull request as draft January 11, 2024 14:32
@Rich-Harris
Copy link
Member

#11191 was merged, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants