Skip to content

docs: add details to discloseVersion #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024
Merged

docs: add details to discloseVersion #10274

merged 1 commit into from
Jan 25, 2024

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jan 23, 2024

Not sure why this is generating a CompileOptions and CompileOptions_1...

I wasn't sure whether to send this against main or svelte-4. I sent it against main, which won't update the current site, but since it's the JSDoc and not the site itself, I wasn't sure if I should sent it against svelte-4 or not.

Copy link

changeset-bot bot commented Jan 23, 2024

⚠️ No Changeset found

Latest commit: 8c58eee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

I daresay we need both

@Rich-Harris Rich-Harris merged commit 821a213 into main Jan 25, 2024
@Rich-Harris Rich-Harris deleted the discloseVersionDocs branch January 25, 2024 23:10
trueadm pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants