Skip to content

chore: simplify code #10294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2024
Merged

chore: simplify code #10294

merged 3 commits into from
Jan 26, 2024

Conversation

Rich-Harris
Copy link
Member

this is faster and less code

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: e0694f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

There's been a push I've noticed elsewhere in the browser runtime to use vars for performance reasons. Is that something we want to still keep doing?

@Rich-Harris
Copy link
Member Author

Yeah, I think we should. Though I went to edit this PR just now and it would have meant either a) leaving a bunch of var declarations right next to const and let declarations or b) making this PR much larger. I reckon we should change them en masse in a separate PR. would be nice if there was a lint rule or something that helped us enforce it in non-loop cases

@Rich-Harris Rich-Harris merged commit 07a0ae4 into main Jan 26, 2024
@Rich-Harris Rich-Harris deleted the tweak branch January 26, 2024 00:39
trueadm pushed a commit that referenced this pull request Jan 31, 2024
* chore: simplify code

* a few more

* constify

---------

Co-authored-by: Rich Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants