Skip to content

fix: improve unstate handling of non enumerable properties #10348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: improve unstate handling of non enumerable properties #10348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
936919a
fix: improve unstate handling of non enumerable properties
trueadm Jan 31, 2024
eb33bd1
Update packages/svelte/src/internal/client/proxy.js
dummdidumm Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-radios-exercise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: improve unstate handling of non enumerable properties
3 changes: 2 additions & 1 deletion packages/svelte/src/internal/client/proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,11 @@ function unwrap(value, already_unwrapped = new Map()) {
} else {
/** @type {Record<string | symbol, any>} */
const obj = {};
const keys = object_keys(value);
const keys = Reflect.ownKeys(value);
const descriptors = get_descriptors(value);
already_unwrapped.set(value, obj);
for (const key of keys) {
if (key === STATE_SYMBOL || (DEV && key === READONLY_SYMBOL)) continue;
if (descriptors[key].get) {
define_property(obj, key, descriptors[key]);
} else {
Expand Down