Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few small tweaks:
read_context
is nowread_pattern
which is a better nameparser.append
calls have been annotated. the annotations look a bit roundabout, but this is the equivalent of doingparser.append<type>(...)
which is otherwise impossible in JSDoc. This is better than the previous approach of awkwardly typing the argument — it's safer (it already caught a type error, oops) and doesn't require us to useOmit
typeAnnotation
to theestree
BaseNode