Skip to content

Tidy up parser #10407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Tidy up parser #10407

merged 2 commits into from
Feb 5, 2024

Conversation

Rich-Harris
Copy link
Member

a few small tweaks:

  • read_context is now read_pattern which is a better name
  • its return value is typed, providing more type safety
  • parser.append calls have been annotated. the annotations look a bit roundabout, but this is the equivalent of doing parser.append<type>(...) which is otherwise impossible in JSDoc. This is better than the previous approach of awkwardly typing the argument — it's safer (it already caught a type error, oops) and doesn't require us to use Omit
  • added typeAnnotation to the estree BaseNode

Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: 0595770

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant