Skip to content

fix: set open binding value in <details> #10413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strange-apricots-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: set `open` binding value in `<details>`
1 change: 1 addition & 0 deletions packages/svelte/src/compiler/phases/bindings.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export const binding_properties = {
textContent: {},
open: {
event: 'toggle',
type: 'set',
valid_elements: ['details']
},
value: {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { ok, test } from '../../test';

export default test({
test({ assert, target }) {
const details_el = target.querySelector('details');

ok(details_el);

assert.strictEqual(details_el.open, true);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<script>
let open = $state(true);
</script>

<details bind:open>
<summary>Details</summary>
...
</details>