Skip to content

fix: allow stores in transition,animation,use directives #10481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

navorite
Copy link
Contributor

@navorite navorite commented Feb 14, 2024

I'm not sure if this should be the output for SSR, but it's harmless either way.

closes #9518

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: 4eac5ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Feb 14, 2024

We ideally don't want that in the SSR output. It would be great if we could avoid it.

@navorite
Copy link
Contributor Author

@trueadm can you take a look now?

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@trueadm trueadm merged commit 3f75ea6 into sveltejs:main Feb 16, 2024
@navorite navorite deleted the transition-directive-store branch February 16, 2024 17:19
@Rich-Harris Rich-Harris mentioned this pull request Feb 16, 2024
5 tasks
Rich-Harris added a commit that referenced this pull request Feb 16, 2024
* simplify

* replace snapshot test with runtime test

* this is overkill

---------

Co-authored-by: Rich Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use a store with the $ prefix with in:, out: or transition:
2 participants