-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: ignore test directories left over from other branches #10525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
'Months'? #1391 I'm a little confused by this implementation, though. Why are you looking for files that don't begin with |
I don't think a |
At the very least, https://svelte-5-preview-6xrbuwapt-svelte.vercel.app/status appears to be identical to https://svelte-5-preview.vercel.app/status so we're not missing any tests as a result of this |
Though yeah, maybe just ignoring |
packages/svelte/tests/suite.ts
Outdated
// skip directories that don't have any files without _ prefix — these | ||
// are leftover from a different branch, and will cause annoying errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment needs updating now, but I do feel more comfortable with this more conservative change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, i just removed it altogether since the other comment right above it serves the same purpose
should have done this months ago