Skip to content

chore: ignore test directories left over from other branches #10525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

Rich-Harris
Copy link
Member

should have done this months ago

Copy link

changeset-bot bot commented Feb 18, 2024

⚠️ No Changeset found

Latest commit: e38bf5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

'Months'? #1391

I'm a little confused by this implementation, though. Why are you looking for files that don't begin with _? Is it just _output that you don't want to consider? A lot of the time, a _config.js file is a strong indicator that this is a test we want to run.

@Rich-Harris
Copy link
Member Author

I don't think a _config.js would ever be unaccompanied by an input.svelte or index.svelte or main.svelte or whatever (side-note: should probably make those more consistent)

@Rich-Harris
Copy link
Member Author

At the very least, https://svelte-5-preview-6xrbuwapt-svelte.vercel.app/status appears to be identical to https://svelte-5-preview.vercel.app/status so we're not missing any tests as a result of this

@Rich-Harris
Copy link
Member Author

Though yeah, maybe just ignoring _output and _actual.json would yield the same result with less danger

Comment on lines 85 to 86
// skip directories that don't have any files without _ prefix — these
// are leftover from a different branch, and will cause annoying errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs updating now, but I do feel more comfortable with this more conservative change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, i just removed it altogether since the other comment right above it serves the same purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants