Skip to content

simplify test #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024
Merged

simplify test #10538

merged 1 commit into from
Feb 19, 2024

Conversation

Rich-Harris
Copy link
Member

see #10535 (comment) — in general I think it's worth writing tests as hygienically and idiomatically as possible, since test code tends to get copied around a bit and it's important for it to have as little cognitive overhead as possible (I often find myself reverse engineering the intent of a particular test)

Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: e6ee745

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant