Skip to content

Blockless redux #10794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 13, 2024
Merged

Blockless redux #10794

merged 10 commits into from
Mar 13, 2024

Conversation

Rich-Harris
Copy link
Member

This marks the start of another run at #10594 — trying to do it in a more incremental fashion this time. This does mean that things may look suboptimal initially.

Right now, block effects and their branch effects (still workshopping these names) are created as siblings. Because of that, we have to do things like this:

if (type === IF_BLOCK) {
  // a bunch of special logic, far from the if block definition
}

If we just construct the tree correctly in the first place, that becomes unnecessary. Eventually, the block construct itself (as distinct from the block effect) also becomes unnecessary, and we can greatly simplify things like transitions.

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: ec78d5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit ffb27f6 into main Mar 13, 2024
@Rich-Harris Rich-Harris deleted the blockless-redux branch March 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants