Skip to content

chore: more hydration stuff #10896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2024
Merged

chore: more hydration stuff #10896

merged 6 commits into from
Mar 24, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Mar 23, 2024

more small tweaks:

  • child_frag is a rather confusing name. changed it to first_child
  • inside open_template, hydrate_nodes is always populated while hydrating — means we can delete some code
  • replaced the slightly opaque ternary in close_template with a documented if block
  • replaced Array.from(childNodes) with [...childNodes], after benchmarking it

Copy link

changeset-bot bot commented Mar 23, 2024

⚠️ No Changeset found

Latest commit: 42f3c92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 32b1824 into main Mar 24, 2024
@Rich-Harris Rich-Harris deleted the more-hydration-stuff branch March 24, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants