Skip to content

feat: use short comments #10899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2024
Merged

feat: use short comments #10899

merged 3 commits into from
Mar 24, 2024

Conversation

Rich-Harris
Copy link
Member

Closes #10609. So far, this just replaces <!--x--> with <!x>. I seem to recall there being some issue with JSDOM (or something) not recognising these as comments, but it appears to no longer be an issue.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 23, 2024

⚠️ No Changeset found

Latest commit: 5b6da07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Mar 24, 2024

I wasn't sure if this PR was a draft by accident, but it looks good. Other than the failing test.

@Rich-Harris
Copy link
Member Author

Draft because I have a whole bunch of follow-up work planned, but I think it might be better to tackle things in stages, so I'll merge this once green

@Rich-Harris Rich-Harris marked this pull request as ready for review March 24, 2024 15:25
@Rich-Harris Rich-Harris merged commit 7e5e462 into main Mar 24, 2024
@Rich-Harris Rich-Harris deleted the gh-10609 branch March 24, 2024 15:25
@michael
Copy link

michael commented Mar 24, 2024

Speaking of comments... I have no good idea for a syntax, but it'd be neat to be able to just comment out props temporarily. E.g.:

<Foo
 /*bar="bar"*/
 baz="baz"
/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte 5: more efficient SSR output
3 participants