Skip to content

feat: use bracket matching instead of ssr:n comments #10904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

Rich-Harris
Copy link
Member

Per #10609, it's simpler and more efficient to do this...

<![>stuff<!]>

...than this:

<!ssr:0>stuff<!ssr:0>

It's smaller and less noisy, but it's also much clearer which comments represent the start vs the end of a block. It also makes SSR more efficient, because we don't need to create a bunch of incrementing anchors — we can just use string literals.

The {@html '<p>invalid</p>'} tests were failing with that change due to some quirk or other — this was fixed by clearing out container.textContent in render.js on hydration failure rather than removing nodes individually (which for whatever reason left some nodes behind). I would expect clearing the text content to be more efficient anyway; it's certainly simpler.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 24, 2024

⚠️ No Changeset found

Latest commit: 1e6c37a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PatrickG
Copy link
Member

This is somewhat related.
It is about a {#each}-block inside of <svelte:head> which renders a <title> with the help of <svelte:element>. So the SSRd <title> tag ends up with HTML comments in it.
And it seems like it would still be a problem with this changes.

@Rich-Harris Rich-Harris merged commit 8685d49 into main Mar 25, 2024
@Rich-Harris Rich-Harris deleted the ssr-comment-brackets branch March 25, 2024 13:05
@Rich-Harris
Copy link
Member Author

We're going to need a separate issue for the <title> thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants