feat: use bracket matching instead of ssr:n
comments
#10904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #10609, it's simpler and more efficient to do this...
...than this:
It's smaller and less noisy, but it's also much clearer which comments represent the start vs the end of a block. It also makes SSR more efficient, because we don't need to create a bunch of incrementing anchors — we can just use string literals.
The
{@html '<p>invalid</p>'}
tests were failing with that change due to some quirk or other — this was fixed by clearing outcontainer.textContent
inrender.js
on hydration failure rather than removing nodes individually (which for whatever reason left some nodes behind). I would expect clearing the text content to be more efficient anyway; it's certainly simpler.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint