Skip to content

chore: optimise attributes #10916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2024
Merged

chore: optimise attributes #10916

merged 5 commits into from
Mar 25, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Mar 25, 2024

In this PR, attribute values are stored on an element.__attributes object, which allows us to determine whether or not an attribute needs to be updated without touching the DOM.

It will enable us to get rid of the if (div_blah !== (div_blah = whatever())) stuff, which — as well as making compiler output more efficient — will make render effects more performant by avoiding the deopts that result from closures referencing values that get reassigned. (At least, that's what @trueadm tells me.) That will happen in a follow-up PR.

By calling element.getAttribute(...) exactly once, during hydration, we also solve #10914. I guess I should add a test for that. actually no, this doesn't fix that issue yet — need to get rid of the if blocks first

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: df7071c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 7e584e4 into main Mar 25, 2024
if (hydrating) {
attributes[attribute] = element.getAttribute(attribute);

if (attribute === 'src' || attribute === 'href' || attribute === 'srcset') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the DEV condition

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These attributes are skipped in dev and prod mode. The only difference is that in dev mode we additionally warn, which is what happens on the next line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants