Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, attribute values are stored on an
element.__attributes
object, which allows us to determine whether or not an attribute needs to be updated without touching the DOM.It will enable us to get rid of the
if (div_blah !== (div_blah = whatever()))
stuff, which — as well as making compiler output more efficient — will make render effects more performant by avoiding the deopts that result from closures referencing values that get reassigned. (At least, that's what @trueadm tells me.) That will happen in a follow-up PR.By calling
element.getAttribute(...)
exactly once, during hydration, we also solve #10914.I guess I should add a test for that.actually no, this doesn't fix that issue yet — need to get rid of theif
blocks firstBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint