Skip to content

chore: simplify updates #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 25, 2024
Merged

chore: simplify updates #10922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c85339
remove if blocks around attribute updates
Rich-Harris Mar 25, 2024
13f5c21
remove singular updates
Rich-Harris Mar 25, 2024
3f68750
simplify
Rich-Harris Mar 25, 2024
3902291
get rid of text_effect
Rich-Harris Mar 25, 2024
4b508ce
get rid of class_toggle_effect and style_effect
Rich-Harris Mar 25, 2024
630e571
merge main
Rich-Harris Mar 25, 2024
8c11e70
remove spread_attributes_effect
Rich-Harris Mar 25, 2024
7219b9e
simplify
Rich-Harris Mar 25, 2024
ebe2ede
simplify
Rich-Harris Mar 25, 2024
a212b0f
simplify
Rich-Harris Mar 25, 2024
0f56430
remove unused stuff
Rich-Harris Mar 25, 2024
bfd9570
get rid of spread_dynamic_element_attributes_effect
Rich-Harris Mar 25, 2024
6fde4b5
remove set_custom_element_data_effect
Rich-Harris Mar 25, 2024
2452e22
unused import
Rich-Harris Mar 25, 2024
7c56aa2
more descriptive names
Rich-Harris Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/svelte/src/compiler/phases/3-transform/client/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,7 @@ export interface ComponentClientTransformState extends ClientTransformState {
/** Stuff that happens before the render effect(s) */
readonly init: Statement[];
/** Stuff that happens inside the render effect */
readonly update: {
/** If the update array only contains a single entry, this singular entry will be used, if present */
singular?: Statement;
/** Used if condition for singular prop is false (see comment above) */
grouped: Statement;
}[];
readonly update: Statement[];
/** Stuff that happens after the render effect (control blocks, dynamic elements, bindings, actions, etc) */
readonly after_update: Statement[];
/** The HTML template string */
Expand Down
Loading