chore: tidy up effect init

[Rich-Harris]

The only place we call schedule_effect(effect, true) is inside create_effect. We should therefore move the contents of the if (sync) block inside schedule_effect into create_effect, so that we only need to do that check once, instead of every time the effect is scheduled.

A couple of other small tweaks:

• moved the effect.f |= EFFECT_RAN into create_effect instead of schedule_effect. (We only care about this flag for sync effects)
• moved set_signal_status(effect, CLEAN) into execute_effect — previously, it was being called adjacently to execute_effect, but inconsistently (missing in one case, before execute_effect in another, after it in a third)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1d706db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR