Skip to content

chore: simplify templates #10954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 27, 2024
Merged

chore: simplify templates #10954

merged 10 commits into from
Mar 27, 2024

Conversation

Rich-Harris
Copy link
Member

This simplifies the template logic — fewer function calls, and shorter compiled output (particularly when mixing and matching fragments and elements etc)

-var frag = $.template(`<button> </button>`);
+var root = $.template(`<button> </button>`);

export default function App($$anchor, $$props) {
  $.push($$props, true);

  let count = $.source(0);
-  var button = $.open(frag);
+  var button = root();

  button.__click = [increment, count];

  var text = $.child(button);

  $.render_effect(() => $.set_text(text, `clicks: ${$.stringify($.get(count))}`));
-  $.close($$anchor, button);
+  $.append($$anchor, button);
  $.pop();
}

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 27, 2024

⚠️ No Changeset found

Latest commit: 93fd685

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 326e2b4 into main Mar 27, 2024
@Rich-Harris Rich-Harris deleted the simplify-templates branch March 27, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants