replace skip_if_ssr
and skip_if_hydrate
with modes
#10956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a personal annoyance: often I want to only test SSR or CSR or hydration, but any SSR or CSR-specific logging (or whatever) gets duplicated. It would be nice if we could say 'only run the CSR tests for now'.
This PR replaces
skip_if_ssr
andskip_if_hydrate
with amode
array. There's also askip_mode
array, for temporarily skipping specific modes in a way that gets checked in, but this should be treated as something to tide us over until we get everything passing (like the existing distinction betweentrue
and'permanent'
).