Skip to content

replace skip_if_ssr and skip_if_hydrate with modes #10956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

a personal annoyance: often I want to only test SSR or CSR or hydration, but any SSR or CSR-specific logging (or whatever) gets duplicated. It would be nice if we could say 'only run the CSR tests for now'.

This PR replaces skip_if_ssr and skip_if_hydrate with a mode array. There's also a skip_mode array, for temporarily skipping specific modes in a way that gets checked in, but this should be treated as something to tide us over until we get everything passing (like the existing distinction between true and 'permanent').

Copy link

changeset-bot bot commented Mar 27, 2024

⚠️ No Changeset found

Latest commit: d85e43c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 2079e67 into main Mar 27, 2024
@Rich-Harris Rich-Harris deleted the test-modes branch March 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants