Skip to content

chore: use internal doubly linked listed for effect tree #10994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 30, 2024

By adopting a doubly linked list, we can improve performance of effect removals and also streamline a bunch of logic that is currently recursive (I added TODOs).

Copy link

changeset-bot bot commented Mar 30, 2024

⚠️ No Changeset found

Latest commit: c3db01e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trueadm trueadm merged commit 3f6eff5 into main Mar 30, 2024
@trueadm trueadm deleted the linked-list branch March 30, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants