-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: add test to show usage of context in component template #11061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
nice! can we get a test up in here though? 🙏 |
This is a significant breaking change with v4, that sort of code is out there, I've seen it. |
Blurgh. Is our conclusion from that 'make this a warning in 5 and an error in 6', or 'don't change it'? |
Should I make this a warning then or close it? I'm happy to do either. We could also make it an error in runes mode only? |
Also encountered this pattern. I think these use cases are legitimate. So I guess I lean towards 'close it' (though maybe we should add a test to make sure we don't accidentally break this) |
Cool. Rather than close this and lose context, I just repurposed the PR to add a test case to ensure we can continue to use context in the template. |
Ensures Svelte 5 tackles the issue in #7549 for client side usage of
getContext
in places where it's not valid to be used.