Skip to content

chore: tidy up messages #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Apr 25, 2024
Merged

chore: tidy up messages #11327

merged 38 commits into from
Apr 25, 2024

Conversation

Rich-Harris
Copy link
Member

This makes a start on the incredibly tedious task of auditing our errors and warning messages, to give them more sensible codes and to deduplicate things where possible.

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: e281ab5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris marked this pull request as ready for review April 25, 2024 02:50
@Rich-Harris
Copy link
Member Author

Still a handful of runtime errors to convert, but this is ready for review. Almost at the point where we can add this stuff to the appendix of the docs


> <%name%> should not have aria-* attributes
> Avoid using accesskey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you want to make this part of this PR, but we have https://svelte.dev/docs/accessibility-warnings with details on many of those warnings, which you could copy-paste here (and let them get autogenerated later on)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah definitely want to add that, but as a follow-up since this is already a gigantic PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would tell a lie if I said I've read all the messages and codes in-depth, but looks good from a broad view

@Rich-Harris Rich-Harris merged commit 8e17428 into main Apr 25, 2024
@Rich-Harris Rich-Harris deleted the tidy-up-messages branch April 25, 2024 12:54
ota-meshi pushed a commit to sveltejs/eslint-plugin-svelte that referenced this pull request May 7, 2024
I just added Node 22 but CI does not pass in
#750

sveltejs/svelte#11327 changes warning messages,
so I mainly copied exist tests and optimized for Svelte 5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants