-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: tidy up messages #11327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tidy up messages #11327
Conversation
|
Still a handful of runtime errors to convert, but this is ready for review. Almost at the point where we can add this stuff to the appendix of the docs |
|
||
> <%name%> should not have aria-* attributes | ||
> Avoid using accesskey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you want to make this part of this PR, but we have https://svelte.dev/docs/accessibility-warnings with details on many of those warnings, which you could copy-paste here (and let them get autogenerated later on)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah definitely want to add that, but as a follow-up since this is already a gigantic PR
Co-authored-by: Simon H <[email protected]>
Co-authored-by: Simon H <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would tell a lie if I said I've read all the messages and codes in-depth, but looks good from a broad view
I just added Node 22 but CI does not pass in #750 sveltejs/svelte#11327 changes warning messages, so I mainly copied exist tests and optimized for Svelte 5.
This makes a start on the incredibly tedious task of auditing our errors and warning messages, to give them more sensible codes and to deduplicate things where possible.