Skip to content

fix: key in p could fail if p is null #11388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 10, 2024
Merged

fix: key in p could fail if p is null #11388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d4dac83
fix: `key in p` could fail if `p` is null
fsoft72 Apr 30, 2024
1ab5e0f
Update packages/svelte/src/internal/client/reactivity/props.js
fsoft72 May 2, 2024
d69aedb
Merge branch 'sveltejs:main' into main
fsoft72 May 8, 2024
1ee5c2d
fix: `key in p` could fail if `p` is null
fsoft72 Apr 30, 2024
c60d0ca
Update packages/svelte/src/internal/client/reactivity/props.js
fsoft72 May 2, 2024
e886947
Merge branch 'main' of github.com:fsoft72/svelte
fsoft72 May 8, 2024
2790d16
fix: Add Child component and props to prop-p-is-null sample
fsoft72 May 8, 2024
bd68d68
Delete packages/svelte/tests/runtime-legacy/samples/prop-p-is-null/ou…
dummdidumm May 8, 2024
0b099b2
fix
dummdidumm May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/svelte/src/internal/client/reactivity/props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ const spread_props_handler = {
has(target, key) {
for (let p of target.props) {
if (is_function(p)) p = p();
if (key in p) return true;
if (p != null && key in p) return true;
}

return false;
Expand Down
6 changes: 6 additions & 0 deletions packages/svelte/tests/runtime-legacy/samples/prop-p-is-null/Child.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<script>
$: x = Object.keys($$restProps).length;
$: y = Object.keys($$props).length;
</script>

{x} {y}
5 changes: 5 additions & 0 deletions packages/svelte/tests/runtime-legacy/samples/prop-p-is-null/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { test } from '../../test';

export default test({
html: '0 0'
});
5 changes: 5 additions & 0 deletions packages/svelte/tests/runtime-legacy/samples/prop-p-is-null/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<script>
import Child from './Child.svelte'
</script>

<Child {...undefined} />