Skip to content

feat: better autocomplete #11530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2024
Merged

feat: better autocomplete #11530

merged 5 commits into from
May 10, 2024

Conversation

Rich-Harris
Copy link
Member

This scratches a personal itch with the preview site.

Our autocomplete is somewhat buggy:

  • it suggests runes inside strings and comments
  • it suggests nothing for e.g. $effect.
  • for $effect.p it suggests $effect.pre, but then submits $effect$effect.pre(() => {...})
  • it has no awareness of context — it will suggest things like $state in any position, when in reality it is only valid in very specific positions

This PR fixes all those things. It also adds autocomplete for import declarations (though just the module IDs, for now — I feel like if we start adding proper autoimports we'll end up jankily reimplementing the TS language server).

Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 0e79e07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm dummdidumm merged commit 4b7e002 into main May 10, 2024
@dummdidumm dummdidumm deleted the better-autocomplete branch May 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants