Skip to content

feat: error when snippet shadow a prop #11631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2024
Merged

feat: error when snippet shadow a prop #11631

merged 4 commits into from
May 15, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #11603 ...i actually added a warning but i can change that to an error if it's preferred. The phrasing is also up to debate.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: cc8a377

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

I think an error makes more sense because the prop will be completely ignored.

@paoloricciuti paoloricciuti changed the title Warn snippet prop shadowing Error on snippet prop shadowing May 15, 2024
@paoloricciuti paoloricciuti changed the title Error on snippet prop shadowing feat: error when snippet shadow a prop May 15, 2024
@paoloricciuti
Copy link
Member Author

I think an error makes more sense because the prop will be completely ignored.

Yeah it make sense...i went for warn because the whole application might still works but error is better

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 87a420f into sveltejs:main May 15, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error when a {#snippet} hide a props
2 participants