Skip to content

docs:vitest examples path update #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

Bnowako
Copy link

@Bnowako Bnowako commented Jun 2, 2024

Updated outdated path for vitest examples.

Update vitest examples path
Copy link

changeset-bot bot commented Jun 2, 2024

⚠️ No Changeset found

Latest commit: f079695

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

thanks!

@Rich-Harris Rich-Harris merged commit 8892078 into sveltejs:svelte-4 Jun 2, 2024
0 of 2 checks passed
@dominikg
Copy link
Member

dominikg commented Jun 2, 2024

it looks like the svelte example was removed from vitest, so linking to sveltekit that still exists is better than keeping a 404, but we should add back a basic svelte example there.

Esp since the svelte example had used testing-library/svelte too, which the current sveltekit example does not.

it was removed here vitest-dev/vitest#5611

@dominikg
Copy link
Member

dominikg commented Jun 2, 2024

looks like vitest is removing all examples from their repo in the future, we're going to have to set them up our selves.
(sveltekit too)
see https://discord.com/channels/917386801235247114/918057929670811708/1246834765160517632

@benmccann
Copy link
Member

I feel like we don't really need an example because create-svelte sets it up, which basically provides all the example that is needed. But if we had an adder then it could work for non-SvelteKit projects too, which could be nice.

@dominikg
Copy link
Member

dominikg commented Jun 2, 2024

create-svelte doesn't work as documentation. you can't expect people to run that just to figure out how to add vitest after the fact, or even know about that option if they don't have a kit project

@benmccann
Copy link
Member

With svelte-add you don't have to document how to set it up besides running a single command which is so much easier. Perhaps we could build something in that would show you what it'd create if running it on a new project. It could be a cool feature to show you what you'll get. Simon was wanting a dry run command, so it would also help solve some of that need if you could see something on the web before running anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants