feat: defer tasks without creating effects #11960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a handful of places, we're using
effect(...)
to defer work that only needs to happen once (like autofocusing an element). This is overkill — it means creating an effect object, attaching it to the tree, then later 'collecting' the effect during top-down traversal, executing the effect function (which involves checking its dirtiness, setting its status to clean, managing various bits of global state, a nestedtry-catch
, etc) — even if we merge #11955 to mitigate the memory cost.There is a much cheaper and simpler way that already exists in the codebase —
queue_micro_task
.It feels like we could probably use it in more places, but when I tried it causes some tests to fail, likely because of subtle timing issues that don't apply to the things changed in this PR.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint