Skip to content

fix: fix merge style func #11971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2024
Merged

fix: fix merge style func #11971

merged 6 commits into from
Jun 9, 2024

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented Jun 8, 2024

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 8, 2024

🦋 Changeset detected

Latest commit: db8bea7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

What is this fixing?

@azat-io
Copy link
Contributor Author

azat-io commented Jun 8, 2024

I had a problem when using the Shiki Magic Move package (https://github.com/shikijs/shiki-magic-move/blob/main/src/svelte/ShikiMagicMoveRenderer.svelte).

In the style attribute on the first render comes undefined. That's the reason I'm getting the error:

Cannot read properties of undefined (reading 'split')
image

@Rich-Harris
Copy link
Member

Are you able to add a test (or reproduce the bug in https://svelte-5-preview.vercel.app/)?

@Rich-Harris
Copy link
Member

Ah this seems to be enough to reproduce it, but only in SSR (so not in the REPL)

<span style:color="red" style={null}>test</span>

@Rich-Harris Rich-Harris merged commit 088632b into sveltejs:main Jun 9, 2024
8 checks passed
@Rich-Harris
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants