-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: simplify SSR #11977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify SSR #11977
Conversation
|
This has turned into a bit more of a general spring clean. I'm finding so much junk to throw out, feels great |
Ideally we'd move this code around so it isn't in one 2,000+ line module, but I didn't do that for this PR so that it's possible to see what actually changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, looks good to me. I'll defer to @trueadm for final approval because he built much of the initial server compiler and may have more insight.
This simplifies SSR a bit — instead of having
t_string
andt_expression
andt_statement
, we just use ESTree nodes directly. One less wrapper object to deal with, one less type to understand, and it makes a lot of code more compact.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint