Skip to content

chore: add more benchmarks #12108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024
Merged

chore: add more benchmarks #12108

merged 2 commits into from
Jun 20, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jun 20, 2024

Adds more benchmarks.

Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 6e7a6f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but left one question (if you think it should be changed, then it needs to be changed for all files that have an owned benchmark now)

@trueadm trueadm merged commit e9e7d8b into main Jun 20, 2024
7 of 9 checks passed
@trueadm trueadm deleted the more-bench branch June 20, 2024 11:34
FoHoOV pushed a commit to FoHoOV/svelte that referenced this pull request Jun 27, 2024
* chore: add more benchmarks

* address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants