Skip to content

chore: make store initialization logic simpler #12281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

At the moment we have to explicitly check whether stores are initialized on every set, just to handle the edge case that we're setting up a store subscription. Much simpler to just to store.v = blah instead of set(store, blah) in that case, and it quarantines the complexity better

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 3f9b55b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

entry.unsubscribe = subscribe_to_store(store, (v) => set(entry.source, v));
var initial = true;

entry.unsubscribe = subscribe_to_store(store, (v) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a comment explaining why we need to do this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Rich-Harris Rich-Harris merged commit 7e64e84 into main Jul 3, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the simpler-store-fix branch July 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants