Skip to content

fix: create wrapper template for components in HMR mode #12304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #12273, fixes #12280

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: a5c8a30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -279,6 +279,7 @@ export function clean_nodes(
trimmed.length === 1 &&
((first.type === 'RenderTag' && !first.metadata.dynamic) ||
(first.type === 'Component' &&
!state.options.hmr &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably good to have a comment explaining a bit why we can't go without a wrapper in HMR mode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's marge this for now so it unblocks people, we can always have a follow up PR to add comments.

@trueadm trueadm merged commit 445f890 into main Jul 4, 2024
9 checks passed
@trueadm trueadm deleted the gh-12273 branch July 4, 2024 15:27
@@ -279,6 +279,7 @@ export function clean_nodes(
trimmed.length === 1 &&
((first.type === 'RenderTag' && !first.metadata.dynamic) ||
(first.type === 'Component' &&
!state.options.hmr &&
Copy link
Member

@dummdidumm dummdidumm Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal for a comment:

Suggested change
!state.options.hmr &&
// HMR components can be destroyed/recreated independently. In that sense they're a bit
// like a dynamic Svelte component and therefore the anchor is necessary.
!state.options.hmr &&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Regression since next.167 and new regression with next.171 Error on create multiple toasts with svelte-sonner
3 participants