Skip to content

chore: add support for HMR env flag #12420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2024
Merged

chore: add support for HMR env flag #12420

merged 4 commits into from
Jul 12, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 12, 2024

Run this locally:

HMR=true pnpm run test

Interestingly, we have 21 failed tests when doing this.

Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: 36e4c3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

We should probably still allow config.compileOptions to override this — maybe do this instead?

const compileOptions: CompileOptions = {
	generate: 'client',
	rootDir: cwd,
+	dev: process.env.HMR ? true : undefined,
+	hmr: process.env.HMR ? true : undefined,
	...config.compileOptions,
	immutable: config.immutable,
	accessors: 'accessors' in config ? config.accessors : true,
	runes
};

@Rich-Harris Rich-Harris merged commit d967780 into main Jul 12, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the add-hmr-env branch July 12, 2024 14:27
trueadm added a commit that referenced this pull request Jul 16, 2024
* chore: add support for HMR env flag

* chore: add support for HMR env flag

* chore: add support for HMR env flag

* chore: add support for HMR env flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants