chore: tweak test config for hmr test run #12423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
What is the rationale for each of these to not run in hmr mode? |
They don't run in DEV today, trying them in DEV causes them to fail in strange ways. |
Rich-Harris
reviewed
Jul 12, 2024
packages/svelte/tests/runtime-runes/samples/spread-props/_config.js
Outdated
Show resolved
Hide resolved
…ig.js Co-authored-by: Rich Harris <[email protected]>
trueadm
added a commit
that referenced
this pull request
Jul 16, 2024
* conflict * conflict * lint * add comments * Update packages/svelte/tests/runtime-runes/samples/spread-props/_config.js Co-authored-by: Rich Harris <[email protected]> --------- Co-authored-by: Rich Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have two failing tests when running the tests with hmr enabled.