chore: refactor analysis #12651
Merged
chore: refactor analysis #12651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0a3678 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Jul 30, 2024
Comment on lines
133
to
134
| // TODO it would be better to just bail out when we hit the ExportSpecifier node but that's | ||
| // not currently possibly because of our visitor merging, which I desperately want to nuke |
There was a problem hiding this comment.
You nuked it :D
Suggested change
| // TODO it would be better to just bail out when we hit the ExportSpecifier node but that's | |
| // not currently possibly because of our visitor merging, which I desperately want to nuke |
Comment on lines
69
to
70
| // Ideally this would be in the validation file, but that isn't possible because this visitor | ||
| // calls "next" before setting the reactive statements. |
There was a problem hiding this comment.
Outdated
Suggested change
| // Ideally this would be in the validation file, but that isn't possible because this visitor | |
| // calls "next" before setting the reactive statements. |
| e.style_directive_invalid_modifier(node); | ||
| } | ||
|
|
||
| // the case for node.value different from true is already covered by the Identifier visitor |
There was a problem hiding this comment.
Outdated (and now wrong) comment
Suggested change
| // the case for node.value different from true is already covered by the Identifier visitor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been wanting to do this for a long time — have a single visitor per node type in the analysis phase, so we have more precise control and easier-to-follow code
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint