Skip to content

chore: make dev state globally available #12669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024
Merged

chore: make dev state globally available #12669

merged 2 commits into from
Jul 31, 2024

Conversation

Rich-Harris
Copy link
Member

see #12608 (review). It's a bit annoying to have to refer to context.state.options.dev rather than just dev, but it also means that we can't use it inside functions without passing state around.

This PR puts dev in the shared state.js module, which makes everything a bit nicer. We could probably do the same thing with analysis and maybe some other things too.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: 060caa0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member Author

going to do a cheeky self-merge to unblock #12608

@Rich-Harris Rich-Harris merged commit 4b1b886 into main Jul 31, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the state-dev branch July 31, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant