Skip to content

chore: improve constants #12695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 1, 2024
Merged

chore: improve constants #12695

merged 10 commits into from
Aug 1, 2024

Conversation

Rich-Harris
Copy link
Member

This started out as a minor tweak, to use consistent casing for constants, but I soon realised there's a bunch of improvements we can make:

  • we have two constants.js files, that's confusing (even if the intent was to have one that could only be used by compiler code, we weren't doing that consistently)
  • duplication — we don't need both PassiveEvents and PassiveDelegatedEvents
  • more helpers (for example the new is_rune helper gives us type narrowing without forcing ugly casting on the caller side)
  • some things are only used in one module, and should live in that module

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 4c0e4b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 79ef645 into main Aug 1, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the uppercase-constants branch August 1, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant