Skip to content

fix: maintain imports in modules #12704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: maintain imports in modules #12704

merged 2 commits into from
Aug 2, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Aug 2, 2024

Svelte 5 rewrite

Closes #12703

I'm not sure what the test for this should be...a snapshot for the module maybe?

Added a snapshot test

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: befbd8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dominikg
Copy link
Member

dominikg commented Aug 2, 2024

/ecosystem-ci run

@svelte-ecoystem-ci
Copy link

svelte-ecoystem-ci bot commented Aug 2, 2024

📝 Ran ecosystem CI: Open

suite result
eslint-plugin-svelte ✅ success
language-tools ✅ success
mdsvex ❌ failure
melt-ui ❌ failure
melt-ui-preprocessor ✅ success
prettier-plugin-svelte ✅ success
rollup-plugin-svelte ✅ success
skeleton ❌ failure
svelte-eslint-parser ✅ success
svelte-loader ❌ failure
svelte-preprocess ✅ success
sveltekit ❌ failure
vite-plugin-svelte ✅ success

@dominikg
Copy link
Member

dominikg commented Aug 2, 2024

/ecosystem-ci run skeleton

@svelte-ecoystem-ci
Copy link

svelte-ecoystem-ci bot commented Aug 2, 2024

📝 Ran ecosystem CI: Open

suite result
skeleton ❌ failure

@dominikg
Copy link
Member

dominikg commented Aug 2, 2024

skeleton failure also happens on main branch, so likely unrelated to this change https://github.com/sveltejs/svelte-ecosystem-ci/actions/runs/10212752485/job/28256729761

@dummdidumm dummdidumm merged commit 70197fe into sveltejs:main Aug 2, 2024
7 of 9 checks passed
@Rich-Harris
Copy link
Member

oops

@brunnerh
Copy link
Member

brunnerh commented Aug 2, 2024

also RIP changeset

@paoloricciuti
Copy link
Member Author

also RIP changeset

yup for some reason it did not went into changeset but it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected] breaks browser from $app/environment
5 participants