-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: maintain imports in modules #12704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: maintain imports in modules #12704
Conversation
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run skeleton |
skeleton failure also happens on main branch, so likely unrelated to this change https://github.com/sveltejs/svelte-ecosystem-ci/actions/runs/10212752485/job/28256729761 |
oops |
also RIP changeset |
yup for some reason it did not went into changeset but it's fine |
Svelte 5 rewrite
Closes #12703
I'm not sure what the test for this should be...a snapshot for the module maybe?Added a snapshot test
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint