Skip to content

chore: default options.filename to "(unknown)" #12997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

just makes like a little simpler and more consistent (without a breaking change) — closes #12980

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: ecdbed4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg
Copy link
Member

does (unknown) end up in output like sourcemap or the svelte_meta on nodes during dev? that could lead to subsequent errors, although i am not sure how well these would fare with the current undefined.

@Rich-Harris
Copy link
Member Author

Probably. But if you're not supplying a filename it's because you're doing things by hand (no bundler plugin etc) and need to understand what you're doing anyway. The alternative would be to make the filename option required

@trueadm
Copy link
Contributor

trueadm commented Aug 24, 2024

I think we should probably try and make it required but this is a good half-way step.

@Rich-Harris Rich-Harris merged commit c5c54da into main Aug 24, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the required-filename branch August 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: make filename option mandatory
3 participants