Skip to content

fix: handle deletions of state proxy properties #13008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2024
Merged

fix: handle deletions of state proxy properties #13008

merged 1 commit into from
Aug 24, 2024

Conversation

Rich-Harris
Copy link
Member

closes #13003. We were doing a couple of things wrong — the deleteProperty trap should always return true, not just when the property previously existed (I was surprised by this, but try it — delete {}.foo), and we need to create an UNINITIALIZED source when deleting a property that exists on the target otherwise it will show up in ownKeys

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 24, 2024

🦋 Changeset detected

Latest commit: a604efd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit cb4f82f into main Aug 24, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the gh-13003 branch August 24, 2024 21:37
@bartpype
Copy link
Contributor

Thank you Rich for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: weird behaviour change since svelte5@227
2 participants