Skip to content

fix: follow spec for customElement option #13247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

wackbyte
Copy link
Contributor

@wackbyte wackbyte commented Sep 15, 2024

Fixes #13244. Follows the WHATWG spec when validating the customElement option in <svelte:options>.

This is technically a breaking change because the validator would no longer accept uppercase letters in customElement; however, any code that did do this is invalid and would error immediately at runtime anyway, so I argue that it isn't a breaking change.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 15, 2024

🦋 Changeset detected

Latest commit: 8cc5dbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit e3ad1ac into sveltejs:main Sep 15, 2024
7 of 9 checks passed
@Rich-Harris
Copy link
Member

thank you!

@wackbyte wackbyte deleted the custom-element-name branch September 16, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Elements can have a tag name ending with a hyphen
2 participants