Skip to content

fix: treat imports as potentially reactive #13265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Rich-Harris
Copy link
Member

fixes #13212. supersedes #13264

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: fc16c52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Sep 16, 2024

I originally did this too, but @dummdidumm mentioned in the linked issue that only handling imports wasn't sufficient. Happy to go for either way. i.e. you did this:

<script>
  import * as foo from './stuff.svelte.js';

  const stuff = foo.stuff;
</script>

<button onclick={() => Object.assign(stuff, { x: 1 })}>1</button>
<button onclick={() => Object.assign(stuff, { x: 2 })}>2</button>
<p>{Object.values(stuff)}</p>

@Rich-Harris
Copy link
Member Author

True. I think we should do #13266 so that we can preserve the optimal behaviour while maintaining correctness. Closing until then

@dummdidumm dummdidumm deleted the treat-imports-as-state branch September 16, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When passing an imported $state as Object.values() to an external component reactivity does not work
2 participants