Skip to content

fix: mark nesting selectors of global parents as used #13445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: mark nesting selectors of global parents as used #13445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/svelte/src/compiler/phases/2-analyze/css/css-analyze.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,19 @@ const css_visitors = {
node.metadata.used ||= node.children.every(
({ metadata }) => metadata.is_global || metadata.is_global_like
);

if (
node.metadata.rule?.metadata.parent_rule &&
node.children[0]?.selectors[0]?.type === 'NestingSelector'
) {
const parent_is_global = node.metadata.rule.metadata.parent_rule.prelude.children.some(
(child) => child.children.length === 1 && child.children[0].metadata.is_global
);
// mark `&:hover` in `:global(.foo) { &:hover { color: green }}` as used
if (parent_is_global) {
node.metadata.used = true;
}
}
},
RelativeSelector(node, context) {
node.metadata.is_global = node.selectors.length >= 1 && is_global(node);
Expand Down
30 changes: 22 additions & 8 deletions packages/svelte/tests/css/samples/global-nested-block/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,46 @@ import { test } from '../../test';

export default test({
warnings: [
{
code: 'css_unused_selector',
message: 'Unused CSS selector ".unused"',
start: {
line: 19,
column: 3,
character: 204
},
end: {
line: 19,
column: 10,
character: 211
}
},
{
code: 'css_unused_selector',
message: 'Unused CSS selector ".unused :global"',
start: {
line: 25,
line: 34,
column: 2,
character: 229
character: 332
},
end: {
line: 25,
line: 34,
column: 17,
character: 244
character: 347
}
},
{
code: 'css_unused_selector',
message: 'Unused CSS selector ".unused :global(.z)"',
start: {
line: 31,
line: 40,
column: 2,
character: 283
character: 386
},
end: {
line: 31,
line: 40,
column: 21,
character: 302
character: 405
}
}
]
Expand Down
9 changes: 9 additions & 0 deletions packages/svelte/tests/css/samples/global-nested-block/expected.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@

.x {
color: green;
&:hover {
color: green;
}
&div {
color: green;
}
/* (unused) .unused {
color: red;
}*/
}

p:where(.svelte-xyz) {
Expand Down
9 changes: 9 additions & 0 deletions packages/svelte/tests/css/samples/global-nested-block/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@

:global(.x) {
color: green;
&:hover {
color: green;
}
&div {
color: green;
}
.unused {
color: red;
}
}

p :global {
Expand Down