Skip to content

docs: Reference svelte/reactivity from $state. #13571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

brunnerh
Copy link
Member

@brunnerh brunnerh commented Oct 11, 2024

Make it easier to find SvelteSet, SvelteMap, etc.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
    ^ still broken for me

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: d4f33d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

@brunnerh it looks like there's a merge conflict in this PR. could you update it? thanks!

@brunnerh
Copy link
Member Author

@benmccann That part of the docs has been significantly restructured and that NOTE no longer exists.
I added the reference in a different spot but I'm not sure whether it's a particularly good one...

@dummdidumm dummdidumm merged commit 69f6b58 into sveltejs:main Oct 23, 2024
7 checks passed
@brunnerh brunnerh deleted the state-reference-reactivity-imports branch October 23, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants