Skip to content

fix: ensure await block scope transforms are isolated #13622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-pans-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure await block scope transforms are isolated
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,34 @@ export function AwaitBlock(node, context) {
let catch_block;

if (node.then) {
const argument = node.value && create_derived_block_argument(node.value, context);
const then_context = {
...context,
state: { ...context.state, transform: { ...context.state.transform } }
};
const argument = node.value && create_derived_block_argument(node.value, then_context);

/** @type {Pattern[]} */
const args = [b.id('$$anchor')];
if (argument) args.push(argument.id);

const declarations = argument?.declarations ?? [];
const block = /** @type {BlockStatement} */ (context.visit(node.then));
const block = /** @type {BlockStatement} */ (then_context.visit(node.then, then_context.state));

then_block = b.arrow(args, b.block([...declarations, ...block.body]));
}

if (node.catch) {
const argument = node.error && create_derived_block_argument(node.error, context);
const catch_context = { ...context, state: { ...context.state } };
const argument = node.error && create_derived_block_argument(node.error, catch_context);

/** @type {Pattern[]} */
const args = [b.id('$$anchor')];
if (argument) args.push(argument.id);

const declarations = argument?.declarations ?? [];
const block = /** @type {BlockStatement} */ (context.visit(node.catch));
const block = /** @type {BlockStatement} */ (
catch_context.visit(node.catch, catch_context.state)
);

catch_block = b.arrow(args, b.block([...declarations, ...block.body]));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
<div title="preserve"></div>
<input type="text" />
<hr />
<f:table></f:table>
<f:table></f:table>
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
child
</Output_1>
<Output_1></Output_1>
{/if}
{/if}
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
child
</Output>
<Output></Output>
{/if}
{/if}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import "svelte/internal/disclose-version";
import * as $ from "svelte/internal/client";

function increment(_, counter) {
counter.count += 1;
}

var root = $.template(`<button> </button> <!> `, 1);

export default function Await_block_scope($$anchor) {
let counter = $.proxy({ count: 0 });
const promise = $.derived(() => Promise.resolve(counter));
var fragment = root();
var button = $.first_child(fragment);

button.__click = [increment, counter];

var text = $.child(button);

$.reset(button);

var node = $.sibling(button, 2);

$.await(node, () => $.get(promise), null, ($$anchor, counter) => {});

var text_1 = $.sibling(node);

$.template_effect(() => {
$.set_text(text, `clicks: ${counter.count ?? ""}`);
$.set_text(text_1, ` ${counter.count ?? ""}`);
});

$.append($$anchor, fragment);
}

$.delegate(["click"]);
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import * as $ from "svelte/internal/server";

export default function Await_block_scope($$payload) {
let counter = { count: 0 };
const promise = Promise.resolve(counter);

function increment() {
counter.count += 1;
}

$$payload.out += `<button>clicks: ${$.escape(counter.count)}</button> <!---->`;
$.await(promise, () => {}, (counter) => {}, () => {});
$$payload.out += `<!----> ${$.escape(counter.count)}`;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<script>
let counter = $state({ count: 0 });
const promise = $derived(Promise.resolve(counter))
function increment() {
counter.count += 1;
}
</script>

<button onclick={increment}>
clicks: {counter.count}
</button>

{#await promise then counter}{/await}

{counter.count}