Skip to content

breaking: stronger enumerated types #13624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 16, 2024
Merged

Conversation

fcrozatier
Copy link
Contributor

Systematic review of all enumerated attributes, with the following modifications:

  • as can be script, image, style etc. (any potential destination)
  • the autocapitalize global attribute
  • the autocorrect attribute
  • dir can be ltr, rtl, auto
  • enctype for forms
  • http-equiv can be a pragma directives like content-security-policy or content-type (but is not needed with the charset attribute and managed csp in kit)
  • kind specifies the type of text track as captions, subtitles etc
  • preload hint to the browser for best user experience
  • the method and formmethod attributes for forms and inputs (ref) and also a method attribute for textPath svg elements
  • the scope of a table header
  • the shape of an area can be circle, rect etc

Also define an HTMLTemplateAttributes for the template element with shadowrootmode

Add the writingsuggestions global attribute

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 4711433

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@trueadm trueadm merged commit 53ae2b8 into sveltejs:main Oct 16, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants