Skip to content

fix : $.component() break transition #13646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix : $.component() break transition #13646

merged 3 commits into from
Oct 17, 2024

Conversation

adiguba
Copy link
Contributor

@adiguba adiguba commented Oct 17, 2024

Fix #13645

The block() used in $.component() must use the flag EFFECT_TRANSPARENT in order to preserve transition.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: cb7f39d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changeset, and then we can merge it :) thanks!

@adiguba
Copy link
Contributor Author

adiguba commented Oct 17, 2024

I added a changeset, but not sure if it's correct like this...

@trueadm trueadm merged commit bb24544 into sveltejs:main Oct 17, 2024
7 of 9 checks passed
@adiguba adiguba deleted the fix-13645 branch October 24, 2024 18:59
@GauBen
Copy link
Contributor

GauBen commented Oct 25, 2024

Hey there! This pull request might have provoked this bug: #13926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: animation not triggered when component imported from index
3 participants