Skip to content

fix: mark :has selectors with multiple preceding selectors as used #13750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/five-zoos-brush.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: mark `:has` selectors with multiple preceding selectors as used
14 changes: 11 additions & 3 deletions packages/svelte/src/compiler/phases/2-analyze/css/css-prune.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,17 @@ function apply_selector(relative_selectors, rule, element, stylesheet, check_has

const possible_match = relative_selector_might_apply_to_node(
relative_selector,
parent_selectors,
rule,
element,
stylesheet,
check_has
);

if (possible_match === 'definite_match') {
return true;
}

if (!possible_match) {
return false;
}
Expand Down Expand Up @@ -388,14 +393,16 @@ const regex_backslash_and_following_character = /\\(.)/g;
* Ensure that `element` satisfies each simple selector in `relative_selector`
*
* @param {Compiler.Css.RelativeSelector} relative_selector
* @param {Compiler.Css.RelativeSelector[]} parent_selectors
* @param {Compiler.Css.Rule} rule
* @param {Compiler.AST.RegularElement | Compiler.AST.SvelteElement} element
* @param {Compiler.Css.StyleSheet} stylesheet
* @param {boolean} check_has Whether or not to check the `:has(...)` selectors
* @returns {boolean}
* @returns {boolean | 'definite_match'}
*/
function relative_selector_might_apply_to_node(
relative_selector,
parent_selectors,
rule,
element,
stylesheet,
Expand Down Expand Up @@ -446,7 +453,7 @@ function relative_selector_might_apply_to_node(
apply_combinator(
left_most_combinator,
selectors[0] ?? [],
[relative_selector],
[...parent_selectors, relative_selector],
rule,
element,
stylesheet,
Expand Down Expand Up @@ -478,7 +485,8 @@ function relative_selector_might_apply_to_node(
}
}

return true;
// We return this to signal the parent "don't bother checking the rest of the selectors, I already did that"
return 'definite_match';
}

for (const selector of other_selectors) {
Expand Down
3 changes: 3 additions & 0 deletions packages/svelte/tests/css/samples/has/expected.css
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,6 @@
/* (unused) x:has(> z) {
color: red;
}*/
x.svelte-xyz > y:where(.svelte-xyz):has(z:where(.svelte-xyz)) {
color: green;
}
3 changes: 3 additions & 0 deletions packages/svelte/tests/css/samples/has/input.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,7 @@
x:has(> z) {
color: red;
}
x > y:has(z) {
color: green;
}
</style>